This repository was archived by the owner on Jan 27, 2026. It is now read-only.
display fix crash in intel_dp_aux_xfer#117
Open
kanlihu wants to merge 1 commit intoprojectceladon:celadon/u/mr0/stablefrom
Open
display fix crash in intel_dp_aux_xfer#117kanlihu wants to merge 1 commit intoprojectceladon:celadon/u/mr0/stablefrom
kanlihu wants to merge 1 commit intoprojectceladon:celadon/u/mr0/stablefrom
Conversation
|
Improper Commit Message |
sysopenci
added
Pending Developer Approval
rdi is 0x00 [21:59:12.977211]: [ 110.603521] ? __intel_tc_port_lock+0xd/0x100 [21:59:12.977320]: [ 110.603748] intel_dp_aux_xfer+0xb3/0x600 Code: 0f 1f 84 00 00 00 00 00 66 66 2e 0f 1f 84 00 00 00 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 41 54 55 89 f5 31 f6 53 <48> 8b 07 48 89 fb 48 83 c7 10 4c 8b 20 e8 21 58 72 00 48 8d bb a8 0 0f 1f 44 00 00 nop dword ptr [rax + rax] 5 41 54 push r12 7 55 push rbp 8 89 f5 mov ebp, esi a 31 f6 xor esi, esi c 53 push rbx d <48> 8b 07 mov rax, qword ptr [rdi] 10 48 89 fb mov rbx, rdi 13 48 83 c7 10 add rdi, 0x10 17 4c 8b 20 mov r12, qword ptr [rax] 1a e8 21 58 72 00 call 0x725840 Tracked-On: IASW-1567 Signed-off-by: Kanli Hu <kanli.hu@intel.com>
feijiang1
reviewed
Mar 24, 2025
|
|
||
| if (is_tc_port) { | ||
| if (!dig_port) { | ||
| ret = -ENXIO; |
There was a problem hiding this comment.
out_fail just "return ret;", why not just return ret here and add additional out_fail?
There was a problem hiding this comment.
additionally suggest add some error log here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdi is 0x00
[21:59:12.977211]: [ 110.603521] ? __intel_tc_port_lock+0xd/0x100
[21:59:12.977320]: [ 110.603748] intel_dp_aux_xfer+0xb3/0x600
Code: 0f 1f 84 00 00 00 00 00 66 66 2e 0f 1f 84 00 00 00 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 41 54 55 89 f5 31 f6 53 <48> 8b 07 48 89 fb 48 83 c7 10 4c 8b 20 e8 21 58 72 00 48 8d bb a8
0 0f 1f 44 00 00 nop dword ptr [rax + rax]
5 41 54 push r12
7 55 push rbp
8 89 f5 mov ebp, esi
a 31 f6 xor esi, esi
c 53 push rbx
d <48> 8b 07 mov rax, qword ptr [rdi]
10 48 89 fb mov rbx, rdi
13 48 83 c7 10 add rdi, 0x10
17 4c 8b 20 mov r12, qword ptr [rax]
1a e8 21 58 72 00 call 0x725840
Tracked-On: IASW-1567